Codecov Report

Attention: Patch coverage is 7.33591% with 240 lines in your changes missing coverage. Please review.

Project coverage is 73.92%. Comparing base (53a04db) to head (2d7863a).

❗ Current head 2d7863a differs from pull request most recent head 66227b7

Please upload reports for the commit 66227b7 to get more accurate results.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Two now identified problems:

Major

• [ ]Problem
  • Failed fields with validation does not block continuing with dialogue screens (i.e. pressing next)
  • Because validation has failed, the tool 'fails' to run CreateConfig with remaining fields (i.e., the resulting object is still created, but 'force' sets all entries to None)
  • Because we can proceed after pressing 'next', we can get to to the end of the questions and tool attempts to write a file. However as config name is now set to None , it fails with a can't None + str error.

Probably due to bad classmethods in utils.py

• Preferred behavior:
  • Validation only occurs if something filled in. If nothing filled in, returns a valid 'no info' entry (which can be subsequently ignored)
  • If validation fails, block next button (unless again reset to empty, or filled in with valid information)

Minor:

• Description always gets written "" even though it should not be written (if description != "" or not None:)